Skip to content

Commit

Permalink
[SCSI] sym53c8xx: Fix NULL pointer dereference in slave_destroy
Browse files Browse the repository at this point in the history
sym53c8xx_slave_destroy unconditionally assumes that sym53c8xx_slave_alloc has
succesesfully allocated a sym_lcb. This can lead to a NULL pointer dereference
(exposed by commit 4e6c82b).

Signed-off-by: Stratos Psomadakis <psomas@gentoo.org>
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Stratos Psomadakis authored and James Bottomley committed Jan 10, 2012
1 parent 9fc397f commit cced504
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/scsi/sym53c8xx_2/sym_glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,10 @@ static void sym53c8xx_slave_destroy(struct scsi_device *sdev)
struct sym_lcb *lp = sym_lp(tp, sdev->lun);
unsigned long flags;

/* if slave_alloc returned before allocating a sym_lcb, return */
if (!lp)
return;

spin_lock_irqsave(np->s.host->host_lock, flags);

if (lp->busy_itlq || lp->busy_itl) {
Expand Down

0 comments on commit cced504

Please sign in to comment.