-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
coccinelle: semantic patch for missing iounmap
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Michal Marek <mmarek@suse.cz>
- Loading branch information
Julia Lawall
authored and
Michal Marek
committed
Feb 24, 2012
1 parent
53302c1
commit cd0207a
Showing
1 changed file
with
67 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /// Find missing iounmaps. | ||
| /// | ||
| //# This only signals a missing iounmap when there is an iounmap later | ||
| //# in the same function. | ||
| //# False positives can be due to loops. | ||
| // | ||
| // Confidence: Moderate | ||
| // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. | ||
| // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. | ||
| // URL: http://coccinelle.lip6.fr/ | ||
| // Comments: | ||
| // Options: | ||
|
|
||
| virtual context | ||
| virtual org | ||
| virtual report | ||
|
|
||
| @iom@ | ||
| expression e; | ||
| statement S,S1; | ||
| int ret; | ||
| position p1,p2,p3; | ||
| @@ | ||
|
|
||
| e = \(ioremap@p1\|ioremap_nocache@p1\)(...) | ||
| ... when != iounmap(e) | ||
| if (<+...e...+>) S | ||
| ... when any | ||
| when != iounmap(e) | ||
| when != if (...) { ... iounmap(e); ... } | ||
| ( | ||
| if (ret == 0) S1 | ||
| | | ||
| if (...) | ||
| { ... | ||
| return 0; } | ||
| | | ||
| if (...) | ||
| { ... | ||
| return <+...e...+>; } | ||
| | | ||
| *if@p2 (...) | ||
| { ... when != iounmap(e) | ||
| when forall | ||
| return@p3 ...; } | ||
| ) | ||
| ... when any | ||
| iounmap(e); | ||
|
|
||
| @script:python depends on org@ | ||
| p1 << iom.p1; | ||
| p2 << iom.p2; | ||
| p3 << iom.p3; | ||
| @@ | ||
| cocci.print_main("ioremap",p1) | ||
| cocci.print_secs("if",p2) | ||
| cocci.print_secs("needed iounmap",p3) | ||
| @script:python depends on report@ | ||
| p1 << iom.p1; | ||
| p2 << iom.p2; | ||
| p3 << iom.p3; | ||
| @@ | ||
| msg = "ERROR: missing iounmap; ioremap on line %s and execution via conditional on line %s" % (p1[0].line,p2[0].line) | ||
| coccilib.report.print_report(p3[0],msg) |