Skip to content

Commit

Permalink
perf tools: Move fs.* to lib/api/fs/
Browse files Browse the repository at this point in the history
Move to generic library and kill magic.h as it is needed only in fs.h.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <rric@kernel.org>
Cc: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: Stephane Eranian <eranian@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1386605664-24041-3-git-send-email-bp@alien8.de
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Borislav Petkov authored and Arnaldo Carvalho de Melo committed Feb 18, 2014
1 parent c9b951c commit cd0cfad
Show file tree
Hide file tree
Showing 11 changed files with 21 additions and 26 deletions.
2 changes: 2 additions & 0 deletions tools/lib/api/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ LIB_H=
LIB_OBJS=

LIB_H += fs/debugfs.h
LIB_H += fs/fs.h

LIB_OBJS += $(OUTPUT)fs/debugfs.o
LIB_OBJS += $(OUTPUT)fs/fs.o

LIBFILE = libapikfs.a

Expand Down
11 changes: 8 additions & 3 deletions tools/perf/util/fs.c → tools/lib/api/fs/fs.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
/* TODO merge/factor in debugfs.c here */

/* TODO merge/factor into tools/lib/lk/debugfs.c */
#include <errno.h>
#include <stdbool.h>
#include <stdio.h>
#include <string.h>
#include <sys/vfs.h>

#include "util.h"
#include "util/fs.h"
#include "debugfs.h"
#include "fs.h"

static const char * const sysfs__fs_known_mountpoints[] = {
"/sys",
Expand Down
12 changes: 5 additions & 7 deletions tools/perf/util/include/linux/magic.h → tools/lib/api/fs/fs.h
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
#ifndef _PERF_LINUX_MAGIC_H_
#define _PERF_LINUX_MAGIC_H_

#ifndef DEBUGFS_MAGIC
#define DEBUGFS_MAGIC 0x64626720
#endif
#ifndef __API_FS__
#define __API_FS__

#ifndef SYSFS_MAGIC
#define SYSFS_MAGIC 0x62656572
Expand All @@ -13,4 +9,6 @@
#define PROC_SUPER_MAGIC 0x9fa0
#endif

#endif
const char *sysfs__mountpoint(void);
const char *procfs__mountpoint(void);
#endif /* __API_FS__ */
3 changes: 0 additions & 3 deletions tools/perf/Makefile.perf
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ LIB_H += util/include/linux/ctype.h
LIB_H += util/include/linux/kernel.h
LIB_H += util/include/linux/list.h
LIB_H += util/include/linux/export.h
LIB_H += util/include/linux/magic.h
LIB_H += util/include/linux/poison.h
LIB_H += util/include/linux/prefetch.h
LIB_H += util/include/linux/rbtree.h
Expand All @@ -244,7 +243,6 @@ LIB_H += util/cache.h
LIB_H += util/callchain.h
LIB_H += util/build-id.h
LIB_H += util/debug.h
LIB_H += util/fs.h
LIB_H += util/pmu.h
LIB_H += util/event.h
LIB_H += util/evsel.h
Expand Down Expand Up @@ -306,7 +304,6 @@ LIB_OBJS += $(OUTPUT)util/annotate.o
LIB_OBJS += $(OUTPUT)util/build-id.o
LIB_OBJS += $(OUTPUT)util/config.o
LIB_OBJS += $(OUTPUT)util/ctype.o
LIB_OBJS += $(OUTPUT)util/fs.o
LIB_OBJS += $(OUTPUT)util/pmu.o
LIB_OBJS += $(OUTPUT)util/environment.o
LIB_OBJS += $(OUTPUT)util/event.o
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/tests/parse-events.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include "parse-events.h"
#include "evsel.h"
#include "evlist.h"
#include "fs.h"
#include <api/fs/fs.h>
#include <api/fs/debugfs.h>
#include "tests.h"
#include <linux/hw_breakpoint.h>
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/cpumap.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "util.h"
#include "fs.h"
#include <api/fs/fs.h>
#include "../perf.h"
#include "cpumap.h"
#include <assert.h>
Expand Down
7 changes: 0 additions & 7 deletions tools/perf/util/fs.h

This file was deleted.

2 changes: 1 addition & 1 deletion tools/perf/util/pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include <unistd.h>
#include <stdio.h>
#include <dirent.h>
#include "fs.h"
#include <api/fs/fs.h>
#include <locale.h>
#include "util.h"
#include "pmu.h"
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/python-ext-sources
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ util/xyarray.c
util/cgroup.c
util/rblist.c
util/strlist.c
util/fs.c
../lib/api/fs/fs.c
util/trace-event.c
../../lib/rbtree.c
2 changes: 1 addition & 1 deletion tools/perf/util/record.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include "evsel.h"
#include "cpumap.h"
#include "parse-events.h"
#include "fs.h"
#include <api/fs/fs.h>
#include "util.h"

typedef void (*setup_probe_fn_t)(struct perf_evsel *evsel);
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/util.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "../perf.h"
#include "util.h"
#include "fs.h"
#include <api/fs/fs.h>
#include <sys/mman.h>
#ifdef HAVE_BACKTRACE_SUPPORT
#include <execinfo.h>
Expand Down

0 comments on commit cd0cfad

Please sign in to comment.