Skip to content

Commit

Permalink
rtc-spear: fix for balancing the enable_irq_wake in Power Mgmt
Browse files Browse the repository at this point in the history
Handle the fix for unbalanced irq for the cases when enable_irq_wake
fails, and a warning related to same is displayed on the console.  The
workaround is handled at the driver level.

Signed-off-by: Deepak Sikri <deepak.sikri@st.com>
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
Acked-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Cc: Shiraz Hashim <shiraz.hashim@st.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Deepak Sikri authored and Linus Torvalds committed Mar 23, 2012
1 parent 0e0cb89 commit cd0e08a
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions drivers/rtc/rtc-spear.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ struct spear_rtc_config {
struct clk *clk;
spinlock_t lock;
void __iomem *ioaddr;
unsigned int irq_wake;
};

static inline void spear_rtc_clear_interrupt(struct spear_rtc_config *config)
Expand Down Expand Up @@ -463,9 +464,10 @@ static int spear_rtc_suspend(struct platform_device *pdev, pm_message_t state)
int irq;

irq = platform_get_irq(pdev, 0);
if (device_may_wakeup(&pdev->dev))
enable_irq_wake(irq);
else {
if (device_may_wakeup(&pdev->dev)) {
if (!enable_irq_wake(irq))
config->irq_wake = 1;
} else {
spear_rtc_disable_interrupt(config);
clk_disable(config->clk);
}
Expand All @@ -481,9 +483,12 @@ static int spear_rtc_resume(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);

if (device_may_wakeup(&pdev->dev))
disable_irq_wake(irq);
else {
if (device_may_wakeup(&pdev->dev)) {
if (config->irq_wake) {
disable_irq_wake(irq);
config->irq_wake = 0;
}
} else {
clk_enable(config->clk);
spear_rtc_enable_interrupt(config);
}
Expand Down

0 comments on commit cd0e08a

Please sign in to comment.