Skip to content

Commit

Permalink
Bluetooth: use list_for_each_entry() in hidp
Browse files Browse the repository at this point in the history
list_for_each_entry is much more meaningful.

Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
  • Loading branch information
Gustavo F. Padovan committed Oct 7, 2011
1 parent 794d175 commit cd11cdd
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions net/bluetooth/hidp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,10 @@ static unsigned char hidp_mkeyspat[] = { 0x01, 0x01, 0x01, 0x01, 0x01, 0x01 };
static struct hidp_session *__hidp_get_session(bdaddr_t *bdaddr)
{
struct hidp_session *session;
struct list_head *p;

BT_DBG("");

list_for_each(p, &hidp_session_list) {
session = list_entry(p, struct hidp_session, list);
list_for_each_entry(session, &hidp_session_list, list) {
if (!bacmp(bdaddr, &session->bdaddr))
return session;
}
Expand Down Expand Up @@ -1140,19 +1138,16 @@ int hidp_del_connection(struct hidp_conndel_req *req)

int hidp_get_connlist(struct hidp_connlist_req *req)
{
struct list_head *p;
struct hidp_session *session;
int err = 0, n = 0;

BT_DBG("");

down_read(&hidp_session_sem);

list_for_each(p, &hidp_session_list) {
struct hidp_session *session;
list_for_each_entry(session, &hidp_session_list, list) {
struct hidp_conninfo ci;

session = list_entry(p, struct hidp_session, list);

__hidp_copy_session(session, &ci);

if (copy_to_user(req->ci, &ci, sizeof(ci))) {
Expand Down

0 comments on commit cd11cdd

Please sign in to comment.