Skip to content

Commit

Permalink
qlcnic: Initialize dcbnl_ops before register_netdev
Browse files Browse the repository at this point in the history
o Initialization of dcbnl_ops after register netdev may result in
  dcbnl_ops not getting set before it is being accessed from open.
  So, moving it before register_netdev.

Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rajesh Borundia authored and David S. Miller committed Aug 5, 2014
1 parent bf63014 commit cd1560e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2323,14 +2323,14 @@ qlcnic_setup_netdev(struct qlcnic_adapter *adapter, struct net_device *netdev,
if (err)
return err;

qlcnic_dcb_init_dcbnl_ops(adapter->dcb);

err = register_netdev(netdev);
if (err) {
dev_err(&pdev->dev, "failed to register net device\n");
return err;
}

qlcnic_dcb_init_dcbnl_ops(adapter->dcb);

return 0;
}

Expand Down

0 comments on commit cd1560e

Please sign in to comment.