Skip to content

Commit

Permalink
drbd: Inlined drbd_free_mdev(); it got called only from one place
Browse files Browse the repository at this point in the history
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
  • Loading branch information
Philipp Reisner committed Nov 8, 2012
1 parent ff370e5 commit cd1d995
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 19 deletions.
1 change: 0 additions & 1 deletion drivers/block/drbd/drbd_int.h
Original file line number Diff line number Diff line change
Expand Up @@ -1366,7 +1366,6 @@ extern rwlock_t global_state_lock;

extern int conn_lowest_minor(struct drbd_tconn *tconn);
enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor, int vnr);
extern void drbd_free_mdev(struct drbd_conf *mdev);
extern void drbd_delete_device(struct drbd_conf *mdev);

struct drbd_tconn *drbd_new_tconn(const char *name);
Expand Down
25 changes: 7 additions & 18 deletions drivers/block/drbd/drbd_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2233,10 +2233,13 @@ void drbd_delete_device(struct drbd_conf *mdev)
kfree(mdev->p_uuid);
/* mdev->p_uuid = NULL; */

/* cleanup the rest that has been
* allocated from drbd_new_device
* and actually free the mdev itself */
drbd_free_mdev(mdev);
kfree(mdev->current_epoch);
if (mdev->bitmap) /* should no longer be there. */
drbd_bm_cleanup(mdev);
__free_page(mdev->md_io_page);
put_disk(mdev->vdisk);
blk_cleanup_queue(mdev->rq_queue);
kfree(mdev);
}

static void drbd_cleanup(void)
Expand Down Expand Up @@ -2551,20 +2554,6 @@ enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor,
return err;
}

/* counterpart of drbd_new_device.
* last part of drbd_delete_device. */
void drbd_free_mdev(struct drbd_conf *mdev)
{
kfree(mdev->current_epoch);
if (mdev->bitmap) /* should no longer be there. */
drbd_bm_cleanup(mdev);
__free_page(mdev->md_io_page);
put_disk(mdev->vdisk);
blk_cleanup_queue(mdev->rq_queue);
kfree(mdev);
}


int __init drbd_init(void)
{
int err;
Expand Down

0 comments on commit cd1d995

Please sign in to comment.