Skip to content

Commit

Permalink
[PATCH] hugetlb: fix error return for brk() entering a hugepage region
Browse files Browse the repository at this point in the history
Commit cb07c9a causes the wrong return
value.  is_hugepage_only_range() is a boolean, so we should return
-EINVAL rather than 1.

Also - we can use "mm" instead of looking up "current->mm" again.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Hugh Dickins authored and Linus Torvalds committed Nov 14, 2006
1 parent 1f794b6 commit cd2579d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions mm/mmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1880,9 +1880,8 @@ unsigned long do_brk(unsigned long addr, unsigned long len)
if ((addr + len) > TASK_SIZE || (addr + len) < addr)
return -EINVAL;

error = is_hugepage_only_range(current->mm, addr, len);
if (error)
return error;
if (is_hugepage_only_range(mm, addr, len))
return -EINVAL;

flags = VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags;

Expand Down

0 comments on commit cd2579d

Please sign in to comment.