Skip to content

Commit

Permalink
[SCSI] libfc: Fix misleading debug statement
Browse files Browse the repository at this point in the history
The statement reads, "Exchange timed out, notifying the upper layer",
however, this statement is printed whenever the timer is armed. This
is confusing to someone debugging the code because every time an
exchange is initialized, there is an incorrect statement stating that
the timer has already timed out. This patch changes the statement to
read, "Exchange timer armed" which is more accurate.

This patch also adds a debug statement in the timeout handler to
properly indicate that the exchange has timed out.

Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
Robert Love authored and James Bottomley committed Sep 5, 2009
1 parent ee610c6 commit cd305ce
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/scsi/libfc/fc_exch.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ static inline void fc_exch_timer_set_locked(struct fc_exch *ep,
if (ep->state & (FC_EX_RST_CLEANUP | FC_EX_DONE))
return;

FC_EXCH_DBG(ep, "Exchange timed out, notifying the upper layer\n");
FC_EXCH_DBG(ep, "Exchange timer armed\n");

if (schedule_delayed_work(&ep->timeout_work,
msecs_to_jiffies(timer_msec)))
Expand Down Expand Up @@ -412,6 +412,8 @@ static void fc_exch_timeout(struct work_struct *work)
u32 e_stat;
int rc = 1;

FC_EXCH_DBG(ep, "Exchange timed out\n");

spin_lock_bh(&ep->ex_lock);
if (ep->state & (FC_EX_RST_CLEANUP | FC_EX_DONE))
goto unlock;
Expand Down

0 comments on commit cd305ce

Please sign in to comment.