Skip to content

Commit

Permalink
[SCTP]: sctp_endpoint_lookup_assoc() switched to net-endian.
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Al Viro authored and David S. Miller committed Dec 3, 2006
1 parent dd86d13 commit cd4ff03
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
10 changes: 5 additions & 5 deletions net/sctp/endpointola.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,16 +257,14 @@ static struct sctp_association *__sctp_endpoint_lookup_assoc(
int rport;
struct sctp_association *asoc;
struct list_head *pos;
union sctp_addr tmp;
flip_to_n(&tmp, paddr);

rport = paddr->v4.sin_port;
rport = ntohs(paddr->v4.sin_port);

list_for_each(pos, &ep->asocs) {
asoc = list_entry(pos, struct sctp_association, asocs);
if (rport == asoc->peer.port) {
sctp_read_lock(&asoc->base.addr_lock);
*transport = sctp_assoc_lookup_paddr(asoc, &tmp);
*transport = sctp_assoc_lookup_paddr(asoc, paddr);
sctp_read_unlock(&asoc->base.addr_lock);

if (*transport)
Expand Down Expand Up @@ -348,8 +346,10 @@ static void sctp_endpoint_bh_rcv(struct sctp_endpoint *ep)
* COOKIE-ECHO chunk.
*/
if (NULL == chunk->asoc) {
union sctp_addr tmp;
flip_to_n(&tmp, sctp_source(chunk));
asoc = sctp_endpoint_lookup_assoc(ep,
sctp_source(chunk),
&tmp,
&transport);
chunk->asoc = asoc;
chunk->transport = transport;
Expand Down
8 changes: 3 additions & 5 deletions net/sctp/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,9 @@ static struct sctp_transport *sctp_addr_id2transport(struct sock *sk,
struct sctp_association *addr_asoc = NULL, *id_asoc = NULL;
struct sctp_transport *transport;
union sctp_addr *laddr = (union sctp_addr *)addr;
union sctp_addr tmp;

flip_to_h(&tmp, laddr);
addr_asoc = sctp_endpoint_lookup_assoc(sctp_sk(sk)->ep,
&tmp,
laddr,
&transport);

if (!addr_asoc)
Expand Down Expand Up @@ -1007,7 +1005,7 @@ static int __sctp_connect(struct sock* sk,
/* Check if there already is a matching association on the
* endpoint (other than the one created here).
*/
asoc2 = sctp_endpoint_lookup_assoc(ep, &to, &transport);
asoc2 = sctp_endpoint_lookup_assoc(ep, sa_addr, &transport);
if (asoc2 && asoc2 != asoc) {
if (asoc2->state >= SCTP_STATE_ESTABLISHED)
err = -EISCONN;
Expand Down Expand Up @@ -1468,7 +1466,7 @@ SCTP_STATIC int sctp_sendmsg(struct kiocb *iocb, struct sock *sk,
/* If a msg_name has been specified, assume this is to be used. */
if (msg_name) {
/* Look for a matching association on the endpoint. */
asoc = sctp_endpoint_lookup_assoc(ep, &to, &transport);
asoc = sctp_endpoint_lookup_assoc(ep, &tmp, &transport);
if (!asoc) {
/* If we could not find a matching association on the
* endpoint, make sure that it is not a TCP-style
Expand Down

0 comments on commit cd4ff03

Please sign in to comment.