Skip to content

Commit

Permalink
[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path
Browse files Browse the repository at this point in the history
from bhalevy@gmail.com:

It looks like change 652 to libiscsi.c added some dead code around line
670
                if (rc) {
                        spin_unlock_bh(&conn->session->lock);
                        goto again;
                }

since 5 lines above we goto again if (rc).

It looks like the previous if (rc) should go away if we want to put the
ctask before
breaking out of the while loop with "goto again" (see following patch).

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Mike Christie authored and James Bottomley committed Oct 25, 2006
1 parent 9864404 commit cd529a4
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/scsi/libiscsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,6 @@ static int iscsi_data_xmit(struct iscsi_conn *conn)
spin_unlock_bh(&conn->session->lock);

rc = tt->xmit_cmd_task(conn, conn->ctask);
if (rc)
goto again;

spin_lock_bh(&conn->session->lock);
__iscsi_put_ctask(conn->ctask);
Expand Down

0 comments on commit cd529a4

Please sign in to comment.