Skip to content

Commit

Permalink
ieee1394: sbp2: use list_move_tail()
Browse files Browse the repository at this point in the history
It's OK to reorder list_del() and sbp2util_free_command_dma() here.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Dec 7, 2006
1 parent 138c8af commit cd641f6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/ieee1394/sbp2.c
Original file line number Diff line number Diff line change
Expand Up @@ -619,9 +619,8 @@ static void sbp2util_mark_command_completed(
struct sbp2_lu *lu,
struct sbp2_command_info *cmd)
{
list_del(&cmd->list);
sbp2util_free_command_dma(cmd);
list_add_tail(&cmd->list, &lu->cmd_orb_completed);
list_move_tail(&cmd->list, &lu->cmd_orb_completed);
}

/*
Expand Down

0 comments on commit cd641f6

Please sign in to comment.