Skip to content

Commit

Permalink
regulator: max8925: Convert to set_voltage_sel() and map_voltage()
Browse files Browse the repository at this point in the history
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Axel Lin authored and Mark Brown committed May 14, 2012
1 parent 4093e73 commit cd8318c
Showing 1 changed file with 8 additions and 15 deletions.
23 changes: 8 additions & 15 deletions drivers/regulator/max8925-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,22 +52,13 @@ static inline int check_range(struct max8925_regulator_info *info,
return 0;
}

static int max8925_set_voltage(struct regulator_dev *rdev,
int min_uV, int max_uV, unsigned int *selector)
static int max8925_set_voltage_sel(struct regulator_dev *rdev,
unsigned int selector)
{
struct max8925_regulator_info *info = rdev_get_drvdata(rdev);
unsigned char data, mask;

if (check_range(info, min_uV, max_uV)) {
dev_err(info->chip->dev, "invalid voltage range (%d, %d) uV\n",
min_uV, max_uV);
return -EINVAL;
}
data = DIV_ROUND_UP(min_uV - info->desc.min_uV, info->desc.uV_step);
*selector = data;
mask = rdev->desc->n_voltages - 1;
unsigned char mask = rdev->desc->n_voltages - 1;

return max8925_set_bits(info->i2c, info->vol_reg, mask, data);
return max8925_set_bits(info->i2c, info->vol_reg, mask, selector);
}

static int max8925_get_voltage_sel(struct regulator_dev *rdev)
Expand Down Expand Up @@ -152,8 +143,9 @@ static int max8925_set_dvm_disable(struct regulator_dev *rdev)
}

static struct regulator_ops max8925_regulator_sdv_ops = {
.map_voltage = regulator_map_voltage_linear,
.list_voltage = regulator_list_voltage_linear,
.set_voltage = max8925_set_voltage,
.set_voltage_sel = max8925_set_voltage_sel,
.get_voltage_sel = max8925_get_voltage_sel,
.enable = max8925_enable,
.disable = max8925_disable,
Expand All @@ -164,8 +156,9 @@ static struct regulator_ops max8925_regulator_sdv_ops = {
};

static struct regulator_ops max8925_regulator_ldo_ops = {
.map_voltage = regulator_map_voltage_linear,
.list_voltage = regulator_list_voltage_linear,
.set_voltage = max8925_set_voltage,
.set_voltage_sel = max8925_set_voltage_sel,
.get_voltage_sel = max8925_get_voltage_sel,
.enable = max8925_enable,
.disable = max8925_disable,
Expand Down

0 comments on commit cd8318c

Please sign in to comment.