Skip to content

Commit

Permalink
[IA64-SGI] fix SGI Altix tioce_reserve_m32() bug
Browse files Browse the repository at this point in the history
The following patch fixes a bug in the SGI Altix tioce_reserve_m32()
code.  The bug was that we could walking past the end of the CE ASIC
32/40bit PMU ATE Buffer, resulting in a PIO Reply Error.

Signed-off-by: Mike Habeck <habeck@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Mike Habeck authored and Tony Luck committed Apr 27, 2006
1 parent 1df57c0 commit cda3d4a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/ia64/sn/pci/tioce_provider.c
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,6 @@ tioce_reserve_m32(struct tioce_kernel *ce_kern, u64 base, u64 limit)
int ate_index, last_ate, ps;
struct tioce *ce_mmr;

if (!TIOCE_M32_ADDR(base))
return;

ce_mmr = (struct tioce *)ce_kern->ce_common->ce_pcibus.bs_base;
ps = ce_kern->ce_ate3240_pagesize;
ate_index = ATE_PAGE(base, ps);
Expand All @@ -693,6 +690,9 @@ tioce_reserve_m32(struct tioce_kernel *ce_kern, u64 base, u64 limit)
if (ate_index < 64)
ate_index = 64;

if (last_ate >= TIOCE_NUM_M3240_ATES)
last_ate = TIOCE_NUM_M3240_ATES - 1;

while (ate_index <= last_ate) {
u64 ate;

Expand Down

0 comments on commit cda3d4a

Please sign in to comment.