Skip to content

Commit

Permalink
mx31moboard: make usbh2 enable gpio claim more atomic
Browse files Browse the repository at this point in the history
It is more cosmetic than fixing a real problem, but the code looks
more logical like that

Signed-off-by: Valentin Longchamp <valentin.longchamp@epfl.ch>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
  • Loading branch information
Valentin Longchamp authored and Sascha Hauer committed Feb 10, 2010
1 parent f8594c2 commit cda82f8
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions arch/arm/mach-mx3/mach-mx31moboard.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,7 @@ static struct fsl_usb2_platform_data usb_pdata = {

static int moboard_usbh2_hw_init(struct platform_device *pdev)
{
int ret = gpio_request(USBH2_EN_B, "usbh2-en");
if (ret)
return ret;
int ret;

mxc_iomux_set_gpr(MUX_PGP_UH2, true);

Expand All @@ -371,6 +369,9 @@ static int moboard_usbh2_hw_init(struct platform_device *pdev)
mxc_iomux_set_pad(MX31_PIN_SRXD3, USB_PAD_CFG);
mxc_iomux_set_pad(MX31_PIN_STXD3, USB_PAD_CFG);

ret = gpio_request(USBH2_EN_B, "usbh2-en");
if (ret)
return ret;
gpio_direction_output(USBH2_EN_B, 0);

return 0;
Expand Down

0 comments on commit cda82f8

Please sign in to comment.