Skip to content

Commit

Permalink
Fix typo in meth driver
Browse files Browse the repository at this point in the history
An | in an if statement to check a bit? I think this needs to be a &.
As a result of this typo meth will always operate in promiscuous mode.

Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Christoph Lameter authored and Jeff Garzik committed Jul 22, 2008
1 parent a6a5325 commit cdc18a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/meth.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ int meth_reset(struct net_device *dev)

/* Initial mode: 10 | Half-duplex | Accept normal packets */
priv->mac_ctrl = METH_ACCEPT_MCAST | METH_DEFAULT_IPG;
if (dev->flags | IFF_PROMISC)
if (dev->flags & IFF_PROMISC)
priv->mac_ctrl |= METH_PROMISC;
mace->eth.mac_ctrl = priv->mac_ctrl;

Expand Down

0 comments on commit cdc18a6

Please sign in to comment.