Skip to content

Commit

Permalink
[PATCH] x86_64: Fix a small missing schedule race
Browse files Browse the repository at this point in the history
Could lead to a lost reschedule event when the process already rescheduled on
exception exit, and needs it again while still being in the kernel.  Unlikely
case though.

Also remove one redundant cli in another entry.S path.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Apr 16, 2005
1 parent 6fefb0d commit cdd219c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86_64/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ int_careful:
pushq %rdi
call schedule
popq %rdi
cli
jmp int_with_check

/* handle signals and tracing -- both require a full stack frame */
Expand Down Expand Up @@ -453,7 +454,6 @@ retint_check:
andl %edi,%edx
jnz retint_careful
retint_swapgs:
cli
swapgs
retint_restore_args:
cli
Expand Down

0 comments on commit cdd219c

Please sign in to comment.