Skip to content

Commit

Permalink
xfs: xfs_iozero can return positive errno
Browse files Browse the repository at this point in the history
It was missed when we converted everything in XFs to use negative error
numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
error sign conversion"), and should go back to stable kernels.

Thanks to Brian Foster for noticing it.

cc: <stable@vger.kernel.org> # 3.17, 3.18, 3.19, 4.0
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
  • Loading branch information
Dave Chinner authored and Dave Chinner committed May 28, 2015
1 parent 6dfe5a0 commit cddc116
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/xfs/xfs_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ xfs_iozero(
status = 0;
} while (count);

return (-status);
return status;
}

int
Expand Down

0 comments on commit cddc116

Please sign in to comment.