Skip to content

Commit

Permalink
bcache: Use uninterruptible sleep in writeback
Browse files Browse the repository at this point in the history
We're just waiting on kthread_should_stop(), nothing else, so
interruptible sleep was wrong here.

Signed-off-by: Kent Overstreet <kmo@daterainc.com>
  • Loading branch information
Kent Overstreet committed Dec 16, 2013
1 parent f665c0f commit ce2b3f5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/md/bcache/writeback.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ static void read_dirty(struct cached_dev *dc)
if (KEY_START(&w->key) != dc->last_read ||
jiffies_to_msecs(delay) > 50)
while (!kthread_should_stop() && delay)
delay = schedule_timeout_interruptible(delay);
delay = schedule_timeout_uninterruptible(delay);

dc->last_read = KEY_OFFSET(&w->key);

Expand Down Expand Up @@ -438,7 +438,7 @@ static int bch_writeback_thread(void *arg)
while (delay &&
!kthread_should_stop() &&
!test_bit(BCACHE_DEV_DETACHING, &dc->disk.flags))
delay = schedule_timeout_interruptible(delay);
delay = schedule_timeout_uninterruptible(delay);
}
}

Expand Down

0 comments on commit ce2b3f5

Please sign in to comment.