Skip to content

Commit

Permalink
macmace, macsonic: cleanup
Browse files Browse the repository at this point in the history
We check ether_type before registering the platform device in
arch/m68k/mac/config.c. Doing the same test again in the driver is
redundant so remove it.

Multiple probes should not happen since the conversion to platform devices,
so lose that test too.

Then macmace.c need not include macintosh.h, so remove that and irq.h and
include linux/interrupt.h explicitly.

Tested on PowerBook 520, Quadra 660av, LC 630.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Finn Thain authored and David S. Miller committed Sep 21, 2011
1 parent 0c07090 commit ce43aa6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
9 changes: 1 addition & 8 deletions drivers/net/ethernet/apple/macmace.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@
#include <linux/dma-mapping.h>
#include <linux/platform_device.h>
#include <linux/gfp.h>
#include <linux/interrupt.h>
#include <asm/io.h>
#include <asm/irq.h>
#include <asm/macintosh.h>
#include <asm/macints.h>
#include <asm/mac_psc.h>
#include <asm/page.h>
Expand Down Expand Up @@ -203,14 +202,8 @@ static int __devinit mace_probe(struct platform_device *pdev)
unsigned char *addr;
struct net_device *dev;
unsigned char checksum = 0;
static int found = 0;
int err;

if (found || macintosh_config->ether_type != MAC_ETHER_MACE)
return -ENODEV;

found = 1; /* prevent 'finding' one on every device probe */

dev = alloc_etherdev(PRIV_BYTES);
if (!dev)
return -ENOMEM;
Expand Down
9 changes: 0 additions & 9 deletions drivers/net/ethernet/natsemi/macsonic.c
Original file line number Diff line number Diff line change
Expand Up @@ -313,22 +313,13 @@ static void __devinit mac_onboard_sonic_ethernet_addr(struct net_device *dev)

static int __devinit mac_onboard_sonic_probe(struct net_device *dev)
{
/* Bwahahaha */
static int once_is_more_than_enough;
struct sonic_local* lp = netdev_priv(dev);
int sr;
int commslot = 0;

if (once_is_more_than_enough)
return -ENODEV;
once_is_more_than_enough = 1;

if (!MACH_IS_MAC)
return -ENODEV;

if (macintosh_config->ether_type != MAC_ETHER_SONIC)
return -ENODEV;

printk(KERN_INFO "Checking for internal Macintosh ethernet (SONIC).. ");

/* Bogus probing, on the models which may or may not have
Expand Down

0 comments on commit ce43aa6

Please sign in to comment.