Skip to content

Commit

Permalink
[PATCH] stack overflow safe kdump: crash: use safe_smp_processor_id()
Browse files Browse the repository at this point in the history
Substitute "smp_processor_id" with the stack overflow-safe
"safe_smp_processor_id" in the reboot path to the second kernel.

[akpm@osdl.org: build fix]
Signed-off-by: Fernando Vazquez <fernando@intellilink.co.jp>
Looks-reasonable-to: Andi Kleen <ak@muc.de>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Vivek Goyal <vgoyal@in.ibm.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Fernando Vazquez authored and Linus Torvalds committed Oct 1, 2006
1 parent 2654c08 commit ce53af9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions arch/i386/kernel/crash.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <asm/hw_irq.h>
#include <asm/apic.h>
#include <asm/kdebug.h>
#include <asm/smp.h>

#include <mach_ipi.h>

Expand Down Expand Up @@ -88,7 +89,7 @@ static void crash_save_self(struct pt_regs *regs)
{
int cpu;

cpu = smp_processor_id();
cpu = safe_smp_processor_id();
crash_save_this_cpu(regs, cpu);
}

Expand Down Expand Up @@ -185,7 +186,7 @@ void machine_crash_shutdown(struct pt_regs *regs)
local_irq_disable();

/* Make a note of crashing cpu. Will be used in NMI callback.*/
crashing_cpu = smp_processor_id();
crashing_cpu = safe_smp_processor_id();
nmi_shootdown_cpus();
lapic_shutdown();
#if defined(CONFIG_X86_IO_APIC)
Expand Down

0 comments on commit ce53af9

Please sign in to comment.