Skip to content

Commit

Permalink
[PATCH] IPoIB: Fix SA client retransmission strategy
Browse files Browse the repository at this point in the history
We got a little mixed up with what the backoff member holds in the
IPoIB multicast group structure: sometimes it was used as a number of
seconds, and sometimes it was used as a number of jiffies.  Fix the
code so that backoff is always in seconds.

Signed-off-by: Hal Rosenstock <halr@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Hal Rosenstock authored and Roland Dreier committed Sep 19, 2005
1 parent d6cff02 commit ce5b65c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/infiniband/ulp/ipoib/ipoib_multicast.c
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ static struct ipoib_mcast *ipoib_mcast_alloc(struct net_device *dev,

mcast->dev = dev;
mcast->created = jiffies;
mcast->backoff = HZ;
mcast->backoff = 1;
mcast->logcount = 0;

INIT_LIST_HEAD(&mcast->list);
Expand Down Expand Up @@ -396,7 +396,7 @@ static void ipoib_mcast_join_complete(int status,
IPOIB_GID_ARG(mcast->mcmember.mgid), status);

if (!status && !ipoib_mcast_join_finish(mcast, mcmember)) {
mcast->backoff = HZ;
mcast->backoff = 1;
down(&mcast_mutex);
if (test_bit(IPOIB_MCAST_RUN, &priv->flags))
queue_work(ipoib_workqueue, &priv->mcast_task);
Expand Down Expand Up @@ -496,7 +496,7 @@ static void ipoib_mcast_join(struct net_device *dev, struct ipoib_mcast *mcast,
if (test_bit(IPOIB_MCAST_RUN, &priv->flags))
queue_delayed_work(ipoib_workqueue,
&priv->mcast_task,
mcast->backoff);
mcast->backoff * HZ);
up(&mcast_mutex);
} else
mcast->query_id = ret;
Expand Down

0 comments on commit ce5b65c

Please sign in to comment.