Skip to content

Commit

Permalink
ARM: Ensure meminfo is sorted prior to sanity_check_meminfo
Browse files Browse the repository at this point in the history
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed May 15, 2010
1 parent 6262c92 commit ceb683d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 0 additions & 10 deletions arch/arm/mm/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <linux/mman.h>
#include <linux/nodemask.h>
#include <linux/initrd.h>
#include <linux/sort.h>
#include <linux/highmem.h>

#include <asm/mach-types.h>
Expand Down Expand Up @@ -387,21 +386,12 @@ static void arm_memory_present(struct meminfo *mi, int node)
}
#endif

static int __init meminfo_cmp(const void *_a, const void *_b)
{
const struct membank *a = _a, *b = _b;
long cmp = bank_pfn_start(a) - bank_pfn_start(b);
return cmp < 0 ? -1 : cmp > 0 ? 1 : 0;
}

void __init bootmem_init(void)
{
struct meminfo *mi = &meminfo;
unsigned long min, max_low, max_high;
int node, initrd_node;

sort(&mi->bank, mi->nr_banks, sizeof(mi->bank[0]), meminfo_cmp, NULL);

/*
* Locate which node contains the ramdisk image, if any.
*/
Expand Down
10 changes: 10 additions & 0 deletions arch/arm/mm/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <linux/bootmem.h>
#include <linux/mman.h>
#include <linux/nodemask.h>
#include <linux/sort.h>

#include <asm/cputype.h>
#include <asm/mach-types.h>
Expand Down Expand Up @@ -1013,6 +1014,13 @@ static void __init kmap_init(void)
#endif
}

static int __init meminfo_cmp(const void *_a, const void *_b)
{
const struct membank *a = _a, *b = _b;
long cmp = bank_pfn_start(a) - bank_pfn_start(b);
return cmp < 0 ? -1 : cmp > 0 ? 1 : 0;
}

/*
* paging_init() sets up the page tables, initialises the zone memory
* maps, and sets up the zero page, bad page and bad page tables.
Expand All @@ -1021,6 +1029,8 @@ void __init paging_init(struct machine_desc *mdesc)
{
void *zero_page;

sort(&meminfo.bank, meminfo.nr_banks, sizeof(meminfo.bank[0]), meminfo_cmp, NULL);

build_mem_type_table();
sanity_check_meminfo();
prepare_page_table();
Expand Down

0 comments on commit ceb683d

Please sign in to comment.