Skip to content

Commit

Permalink
Staging: et131x: tx ring mac error is only used as a local
Browse files Browse the repository at this point in the history
So make it a local

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Dec 11, 2009
1 parent 1458d82 commit ceef1a5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 1 addition & 3 deletions drivers/staging/et131x/et1310_tx.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,7 @@ struct tx_ring {
u32 *tx_status;
dma_addr_t tx_status_pa;

TXMAC_ERR_t TxMacErr;

/* Variables to track the Tx interrupt coalescing features */
/* Packets since the last IRQ: used for interrupt coalescing */
int since_irq;
};

Expand Down
5 changes: 2 additions & 3 deletions drivers/staging/et131x/et131x_isr.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,8 +397,7 @@ void et131x_isr_handler(struct work_struct *work)

/* Let's move on to the TxMac */
if (status & ET_INTR_TXMAC) {
etdev->tx_ring.TxMacErr.value =
readl(&iomem->txmac.err.value);
u32 err = readl(&iomem->txmac.err.value);

/*
* When any of the errors occur and TXMAC generates
Expand All @@ -412,7 +411,7 @@ void et131x_isr_handler(struct work_struct *work)
*/
dev_warn(&etdev->pdev->dev,
"TXMAC interrupt, error 0x%08x\n",
etdev->tx_ring.TxMacErr.value);
err);

/* If we are debugging, we want to see this error,
* otherwise we just want the device to be reset and
Expand Down

0 comments on commit ceef1a5

Please sign in to comment.