Skip to content

Commit

Permalink
ath6kl: fix atomicity in ath6kl_cfg80211_scan_node()
Browse files Browse the repository at this point in the history
ath6kl_cfg80211_scan_node() was calling cfg80211_inform_bss_frame()
with CFP_KERNEL but the function is executed with a spin lock taken.
This is wrong and the function must use GFP_ATOMIC instead.

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
  • Loading branch information
Kalle Valo committed Aug 9, 2011
1 parent b2c76bb commit cf104c2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/wireless/ath/ath6kl/cfg80211.c
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,7 @@ static inline bool is_ch_11a(u16 ch)
return (!((ch >= 2412) && (ch <= 2484)));
}

/* struct ath6kl_node_table::nt_nodelock is locked when calling this */
static void ath6kl_cfg80211_scan_node(void *arg, struct bss *ni)
{
struct wiphy *wiphy = (struct wiphy *)arg;
Expand Down Expand Up @@ -769,7 +770,7 @@ static void ath6kl_cfg80211_scan_node(void *arg, struct bss *ni)
"%s: bssid %pM ch %d freq %d size %d\n", __func__,
mgmt->bssid, channel->hw_value, freq, size);
cfg80211_inform_bss_frame(wiphy, channel, mgmt,
size, signal, GFP_KERNEL);
size, signal, GFP_ATOMIC);

kfree(ieeemgmtbuf);
}
Expand Down

0 comments on commit cf104c2

Please sign in to comment.