Skip to content

Commit

Permalink
[PATCH] FRV: Optimise ffs()
Browse files Browse the repository at this point in the history
Optimise ffs(x) by using fls(x & x - 1) which we optimise to use the SCAN
instruction.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
David Howells authored and Linus Torvalds committed Sep 26, 2006
1 parent a8ad27d commit cf13448
Showing 1 changed file with 31 additions and 2 deletions.
33 changes: 31 additions & 2 deletions include/asm-frv/bitops.h
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,6 @@ static inline int __test_bit(int nr, const volatile void * addr)
__constant_test_bit((nr),(addr)) : \
__test_bit((nr),(addr)))

#include <asm-generic/bitops/ffs.h>
#include <asm-generic/bitops/__ffs.h>
#include <asm-generic/bitops/find.h>

/**
Expand Down Expand Up @@ -227,6 +225,37 @@ int fls64(u64 n)

}

/**
* ffs - find first bit set
* @x: the word to search
*
* - return 32..1 to indicate bit 31..0 most least significant bit set
* - return 0 to indicate no bits set
*/
static inline __attribute__((const))
int ffs(int x)
{
/* Note: (x & -x) gives us a mask that is the least significant
* (rightmost) 1-bit of the value in x.
*/
return fls(x & -x);
}

/**
* __ffs - find first bit set
* @x: the word to search
*
* - return 31..0 to indicate bit 31..0 most least significant bit set
* - if no bits are set in x, the result is undefined
*/
static inline __attribute__((const))
int __ffs(unsigned long x)
{
int bit;
asm("scan %1,gr0,%0" : "=r"(bit) : "r"(x & -x));
return 31 - bit;
}

#include <asm-generic/bitops/sched.h>
#include <asm-generic/bitops/hweight.h>

Expand Down

0 comments on commit cf13448

Please sign in to comment.