Skip to content

Commit

Permalink
perf tools: Create typedef for common event synthesizing callback
Browse files Browse the repository at this point in the history
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1262901583-8074-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Jan 13, 2010
1 parent a89e5ab commit cf55311
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 18 deletions.
16 changes: 5 additions & 11 deletions tools/perf/util/event.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
#include "thread.h"

static pid_t event__synthesize_comm(pid_t pid, int full,
int (*process)(event_t *event,
struct perf_session *session),
event__handler_t process,
struct perf_session *session)
{
event_t ev;
Expand Down Expand Up @@ -91,8 +90,7 @@ static pid_t event__synthesize_comm(pid_t pid, int full,
}

static int event__synthesize_mmap_events(pid_t pid, pid_t tgid,
int (*process)(event_t *event,
struct perf_session *session),
event__handler_t process,
struct perf_session *session)
{
char filename[PATH_MAX];
Expand Down Expand Up @@ -156,9 +154,7 @@ static int event__synthesize_mmap_events(pid_t pid, pid_t tgid,
return 0;
}

int event__synthesize_thread(pid_t pid,
int (*process)(event_t *event,
struct perf_session *session),
int event__synthesize_thread(pid_t pid, event__handler_t process,
struct perf_session *session)
{
pid_t tgid = event__synthesize_comm(pid, 1, process, session);
Expand All @@ -167,8 +163,7 @@ int event__synthesize_thread(pid_t pid,
return event__synthesize_mmap_events(pid, tgid, process, session);
}

void event__synthesize_threads(int (*process)(event_t *event,
struct perf_session *session),
void event__synthesize_threads(event__handler_t process,
struct perf_session *session)
{
DIR *proc;
Expand Down Expand Up @@ -205,8 +200,7 @@ static int find_symbol_cb(void *arg, const char *name, char type, u64 start)
return 1;
}

int event__synthesize_kernel_mmap(int (*process)(event_t *event,
struct perf_session *session),
int event__synthesize_kernel_mmap(event__handler_t process,
struct perf_session *session,
const char *symbol_name)
{
Expand Down
12 changes: 5 additions & 7 deletions tools/perf/util/event.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,13 @@ void event__print_totals(void);

struct perf_session;

int event__synthesize_thread(pid_t pid,
int (*process)(event_t *event,
struct perf_session *session),
typedef int (*event__handler_t)(event_t *event, struct perf_session *session);

int event__synthesize_thread(pid_t pid, event__handler_t process,
struct perf_session *session);
void event__synthesize_threads(int (*process)(event_t *event,
struct perf_session *session),
void event__synthesize_threads(event__handler_t process,
struct perf_session *session);
int event__synthesize_kernel_mmap(int (*process)(event_t *event,
struct perf_session *session),
int event__synthesize_kernel_mmap(event__handler_t process,
struct perf_session *session,
const char *symbol_name);

Expand Down

0 comments on commit cf55311

Please sign in to comment.