Skip to content

Commit

Permalink
ARM: 5812/1: SA1100: h3100/h3600: separate machine-specific LCD helpers
Browse files Browse the repository at this point in the history
h3100 and h3600 have different sets of LCD-controlling gpios,
which mapped to the same "abstracted" EGPIO.
As we plan to get rid of those abstracted egpios completely, we
need to separate these helper functions.

Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Dmitry Artamonow authored and Russell King committed Dec 6, 2009
1 parent 2a83709 commit cf5a87d
Showing 1 changed file with 20 additions and 9 deletions.
29 changes: 20 additions & 9 deletions arch/arm/mach-sa1100/h3600.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,6 @@ static void __init h3xxx_mach_init(void)
sa11x0_register_mtd(&h3xxx_flash_data, &h3xxx_flash_resource, 1);
}

/*
* helper for sa1100fb
*/
static void h3xxx_lcd_power(int enable)
{
assign_h3600_egpio(IPAQ_EGPIO_LCD_POWER, enable);
}

static struct map_desc h3600_io_desc[] __initdata = {
{ /* static memory bank 2 CS#2 */
.virtual = H3600_BANK_2_VIRT,
Expand Down Expand Up @@ -240,7 +232,6 @@ static void __init h3xxx_map_io(void)
PCFR = PCFR_OPDE;
PSDR = 0;

sa1100fb_lcd_power = h3xxx_lcd_power;
}

/************************* H3100 *************************/
Expand Down Expand Up @@ -321,11 +312,21 @@ static void h3100_control_egpio(enum ipaq_egpio_type x, int setp)
| GPIO_H3100_AUD_PWR_ON \
| GPIO_H3100_IR_ON \
| GPIO_H3100_IR_FSEL)
/*
* helper for sa1100fb
*/
static void h3100_lcd_power(int enable)
{
assign_h3600_egpio(IPAQ_EGPIO_LCD_POWER, enable);
}


static void __init h3100_map_io(void)
{
h3xxx_map_io();

sa1100fb_lcd_power = h3100_lcd_power;

/* Initialize h3100-specific values here */
GPCR = 0x0fffffff; /* All outputs are set low by default */
GPDR = GPIO_H3600_L3_CLOCK |
Expand Down Expand Up @@ -455,10 +456,20 @@ static void h3600_control_egpio(enum ipaq_egpio_type x, int setp)
}
}

/*
* helper for sa1100fb
*/
static void h3600_lcd_power(int enable)
{
assign_h3600_egpio(IPAQ_EGPIO_LCD_POWER, enable);
}

static void __init h3600_map_io(void)
{
h3xxx_map_io();

sa1100fb_lcd_power = h3600_lcd_power;

/* Initialize h3600-specific values here */

GPCR = 0x0fffffff; /* All outputs are set low by default */
Expand Down

0 comments on commit cf5a87d

Please sign in to comment.