Skip to content

Commit

Permalink
max17042_battery: Bugfix of incorrect voltage register value interpre…
Browse files Browse the repository at this point in the history
…tation

The calculation had error in getting voltage values from
MAX17042 registers. The least bit denotes 78.125uV (625/8).

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Philip Rakity <prakity@marvell.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
  • Loading branch information
MyungJoo Ham authored and Anton Vorontsov committed Aug 19, 2011
1 parent 91d8b0d commit cf7a8c0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/power/max17042_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,12 @@ static int max17042_get_property(struct power_supply *psy,
val->intval *= 10000; /* Units of LSB = 10mV */
break;
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
val->intval = max17042_read_reg(chip->client,
MAX17042_VCELL) * 83; /* 1000 / 12 = 83 */
val->intval = max17042_read_reg(chip->client, MAX17042_VCELL)
* 625 / 8;
break;
case POWER_SUPPLY_PROP_VOLTAGE_AVG:
val->intval = max17042_read_reg(chip->client,
MAX17042_AvgVCELL) * 83;
val->intval = max17042_read_reg(chip->client, MAX17042_AvgVCELL)
* 625 / 8;
break;
case POWER_SUPPLY_PROP_CAPACITY:
val->intval = max17042_read_reg(chip->client,
Expand Down

0 comments on commit cf7a8c0

Please sign in to comment.