Skip to content

Commit

Permalink
ACPI / LPSS: make code less confusing for reader
Browse files Browse the repository at this point in the history
The excerpt like this:

	if (err) {
		err = 0;
		goto error_out;
	}

makes a reader confused even if it's commented. Let's do necessary actions and
return no error explicitly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Andy Shevchenko authored and Rafael J. Wysocki committed Mar 24, 2013
1 parent 2e0f882 commit cf8df96
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/acpi/acpi_lpss.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
* Skip the device, but don't terminate the namespace
* scan.
*/
ret = 0;
goto err_out;
kfree(pdata);
return 0;
}
}

Expand Down

0 comments on commit cf8df96

Please sign in to comment.