Skip to content

Commit

Permalink
qla2xxx: Remove redundant NULL check before release_firmware() call.
Browse files Browse the repository at this point in the history
release_firmware() checks for NULL pointers internally so checking
before calling it is redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jesper Juhl authored and Jiri Kosina committed Apr 30, 2012
1 parent ee51f44 commit cf92549
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/scsi/qla2xxx/qla_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void)

mutex_lock(&qla_fw_lock);
for (idx = 0; idx < FW_BLOBS; idx++)
if (qla_fw_blobs[idx].fw)
release_firmware(qla_fw_blobs[idx].fw);
release_firmware(qla_fw_blobs[idx].fw);
mutex_unlock(&qla_fw_lock);
}

Expand Down

0 comments on commit cf92549

Please sign in to comment.