Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 325591
b: refs/heads/master
c: 9bb8a3d
h: refs/heads/master
i:
  325589: d2bdfc0
  325587: 2506398
  325583: 7a2e34a
v: v3
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Jun 14, 2012
1 parent 0c1f85c commit cf939c2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: ca4ff100d36b2c1da93a0a121177f73eea154471
refs/heads/master: 9bb8a3d4109f3b267cca9f6f071e2298eed4f593
18 changes: 6 additions & 12 deletions trunk/drivers/tty/tty_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -3144,10 +3144,8 @@ int tty_register_driver(struct tty_driver *driver)
dev = MKDEV(driver->major, driver->minor_start);
error = register_chrdev_region(dev, driver->num, driver->name);
}
if (error < 0) {
kfree(p);
return error;
}
if (error < 0)
goto err_free_p;

if (p) {
driver->ttys = (struct tty_struct **)p;
Expand All @@ -3160,13 +3158,8 @@ int tty_register_driver(struct tty_driver *driver)
cdev_init(&driver->cdev, &tty_fops);
driver->cdev.owner = driver->owner;
error = cdev_add(&driver->cdev, dev, driver->num);
if (error) {
unregister_chrdev_region(dev, driver->num);
driver->ttys = NULL;
driver->termios = NULL;
kfree(p);
return error;
}
if (error)
goto err_unreg_char;

mutex_lock(&tty_mutex);
list_add(&driver->tty_drivers, &tty_drivers);
Expand All @@ -3193,13 +3186,14 @@ int tty_register_driver(struct tty_driver *driver)
list_del(&driver->tty_drivers);
mutex_unlock(&tty_mutex);

err_unreg_char:
unregister_chrdev_region(dev, driver->num);
driver->ttys = NULL;
driver->termios = NULL;
err_free_p:
kfree(p);
return error;
}

EXPORT_SYMBOL(tty_register_driver);

/*
Expand Down

0 comments on commit cf939c2

Please sign in to comment.