Skip to content

Commit

Permalink
m68k: kill skb_copy_from_linear_data compiler warnings
Browse files Browse the repository at this point in the history
The recent conversion from `memcpy' to `skb_copy_from_linear_data' removed a
few casts, which were needed to silence compiler warnings. Re-add them.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Geert Uytterhoeven authored and Linus Torvalds committed May 5, 2007
1 parent 3181757 commit cfa08bb
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
6 changes: 3 additions & 3 deletions drivers/net/7990.c
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,9 @@ int lance_start_xmit (struct sk_buff *skb, struct net_device *dev)
ib->btx_ring [entry].length = (-len) | 0xf000;
ib->btx_ring [entry].misc = 0;

if (skb->len < ETH_ZLEN)
memset((char *)&ib->tx_buf[entry][0], 0, ETH_ZLEN);
skb_copy_from_linear_data(skb, &ib->tx_buf[entry][0], skblen);
if (skb->len < ETH_ZLEN)
memset((void *)&ib->tx_buf[entry][0], 0, ETH_ZLEN);
skb_copy_from_linear_data(skb, (void *)&ib->tx_buf[entry][0], skblen);

/* Now, give the packet to the lance */
ib->btx_ring [entry].tmd1_bits = (LE_T1_POK|LE_T1_OWN);
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/a2065.c
Original file line number Diff line number Diff line change
Expand Up @@ -597,11 +597,11 @@ static int lance_start_xmit (struct sk_buff *skb, struct net_device *dev)
ib->btx_ring [entry].length = (-len) | 0xf000;
ib->btx_ring [entry].misc = 0;

skb_copy_from_linear_data(skb, &ib->tx_buf [entry][0], skblen);
skb_copy_from_linear_data(skb, (void *)&ib->tx_buf [entry][0], skblen);

/* Clear the slack of the packet, do I need this? */
if (len != skblen)
memset ((char *) &ib->tx_buf [entry][skblen], 0, len - skblen);
memset ((void *) &ib->tx_buf [entry][skblen], 0, len - skblen);

/* Now, give the packet to the lance */
ib->btx_ring [entry].tmd1_bits = (LE_T1_POK|LE_T1_OWN);
Expand Down
5 changes: 3 additions & 2 deletions drivers/net/sun3_82586.c
Original file line number Diff line number Diff line change
Expand Up @@ -1023,10 +1023,11 @@ static int sun3_82586_send_packet(struct sk_buff *skb, struct net_device *dev)
{
len = skb->len;
if (len < ETH_ZLEN) {
memset((char *)p->xmit_cbuffs[p->xmit_count], 0, ETH_ZLEN);
memset((void *)p->xmit_cbuffs[p->xmit_count], 0,
ETH_ZLEN);
len = ETH_ZLEN;
}
skb_copy_from_linear_data(skb, p->xmit_cbuffs[p->xmit_count], skb->len);
skb_copy_from_linear_data(skb, (void *)p->xmit_cbuffs[p->xmit_count], skb->len);

#if (NUM_XMIT_BUFFS == 1)
# ifdef NO_NOPCOMMANDS
Expand Down

0 comments on commit cfa08bb

Please sign in to comment.