Skip to content

Commit

Permalink
[SCTP]: Unhash the endpoint in sctp_endpoint_free().
Browse files Browse the repository at this point in the history
This prevents a race between the close of a socket and receive of an
incoming packet.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vlad Yasevich authored and David S. Miller committed Jul 21, 2006
1 parent 37fa687 commit cfdeef3
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions net/sctp/endpointola.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ void sctp_endpoint_add_asoc(struct sctp_endpoint *ep,
void sctp_endpoint_free(struct sctp_endpoint *ep)
{
ep->base.dead = 1;

ep->base.sk->sk_state = SCTP_SS_CLOSED;

/* Unlink this endpoint, so we can't find it again! */
sctp_unhash_endpoint(ep);

sctp_endpoint_put(ep);
}

Expand All @@ -166,11 +172,6 @@ static void sctp_endpoint_destroy(struct sctp_endpoint *ep)
{
SCTP_ASSERT(ep->base.dead, "Endpoint is not dead", return);

ep->base.sk->sk_state = SCTP_SS_CLOSED;

/* Unlink this endpoint, so we can't find it again! */
sctp_unhash_endpoint(ep);

/* Free up the HMAC transform. */
sctp_crypto_free_tfm(sctp_sk(ep->base.sk)->hmac);

Expand Down

0 comments on commit cfdeef3

Please sign in to comment.