Skip to content

Commit

Permalink
ceph: Use kzalloc
Browse files Browse the repository at this point in the history
Use kzalloc rather than the combination of kmalloc and memset.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,size,flags;
statement S;
@@

-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
 if (x == NULL) S
-memset(x, 0, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Julia Lawall authored and Sage Weil committed May 17, 2010
1 parent 167c9e3 commit cffe7b6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/ceph/mon_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -481,11 +481,10 @@ int ceph_monc_do_statfs(struct ceph_mon_client *monc, struct ceph_statfs *buf)
struct ceph_mon_statfs *h;
int err;

req = kmalloc(sizeof(*req), GFP_NOFS);
req = kzalloc(sizeof(*req), GFP_NOFS);
if (!req)
return -ENOMEM;

memset(req, 0, sizeof(*req));
kref_init(&req->kref);
req->buf = buf;
init_completion(&req->completion);
Expand Down

0 comments on commit cffe7b6

Please sign in to comment.