Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 308919
b: refs/heads/master
c: d01dd17
h: refs/heads/master
i:
  308917: 8fc4dfd
  308915: d6af080
  308911: a210cde
v: v3
  • Loading branch information
KAMEZAWA Hiroyuki authored and Linus Torvalds committed May 29, 2012
1 parent b7ba881 commit d01eb31
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2bb2ba9d51a8044a71a29608d2c4ef8f5b2d57a2
refs/heads/master: d01dd17f1067ca50dbb9d1d3400d33221ce339e7
42 changes: 36 additions & 6 deletions trunk/mm/memcontrol.c
Original file line number Diff line number Diff line change
Expand Up @@ -2422,6 +2422,24 @@ static void __mem_cgroup_cancel_charge(struct mem_cgroup *memcg,
}
}

/*
* Cancel chrages in this cgroup....doesn't propagate to parent cgroup.
* This is useful when moving usage to parent cgroup.
*/
static void __mem_cgroup_cancel_local_charge(struct mem_cgroup *memcg,
unsigned int nr_pages)
{
unsigned long bytes = nr_pages * PAGE_SIZE;

if (mem_cgroup_is_root(memcg))
return;

res_counter_uncharge_until(&memcg->res, memcg->res.parent, bytes);
if (do_swap_account)
res_counter_uncharge_until(&memcg->memsw,
memcg->memsw.parent, bytes);
}

/*
* A helper function to get mem_cgroup from ID. must be called under
* rcu_read_lock(). The caller must check css_is_removed() or some if
Expand Down Expand Up @@ -2680,16 +2698,28 @@ static int mem_cgroup_move_parent(struct page *page,
nr_pages = hpage_nr_pages(page);

parent = mem_cgroup_from_cont(pcg);
ret = __mem_cgroup_try_charge(NULL, gfp_mask, nr_pages, &parent, false);
if (ret)
goto put_back;
if (!parent->use_hierarchy) {
ret = __mem_cgroup_try_charge(NULL,
gfp_mask, nr_pages, &parent, false);
if (ret)
goto put_back;
}

if (nr_pages > 1)
flags = compound_lock_irqsave(page);

ret = mem_cgroup_move_account(page, nr_pages, pc, child, parent, true);
if (ret)
__mem_cgroup_cancel_charge(parent, nr_pages);
if (parent->use_hierarchy) {
ret = mem_cgroup_move_account(page, nr_pages,
pc, child, parent, false);
if (!ret)
__mem_cgroup_cancel_local_charge(child, nr_pages);
} else {
ret = mem_cgroup_move_account(page, nr_pages,
pc, child, parent, true);

if (ret)
__mem_cgroup_cancel_charge(parent, nr_pages);
}

if (nr_pages > 1)
compound_unlock_irqrestore(page, flags);
Expand Down

0 comments on commit d01eb31

Please sign in to comment.