Skip to content

Commit

Permalink
x86_64: Move apic calibration code around
Browse files Browse the repository at this point in the history
Let the calibration code fill in calibration_result directly and
move the variable on top of the file.

Fixup a printk w/o log level while at it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
  • Loading branch information
Thomas Gleixner authored and Thomas Gleixner committed Oct 12, 2007
1 parent 500ff08 commit d03030e
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions arch/x86/kernel/apic_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ static struct resource lapic_resource = {
.flags = IORESOURCE_MEM | IORESOURCE_BUSY,
};

static unsigned int calibration_result;

/*
* cpu_mask that denotes the CPUs that needs timer interrupt coming in as
* IPIs in place of local APIC timers
Expand Down Expand Up @@ -821,7 +823,7 @@ static void setup_APIC_timer(unsigned int clocks)

#define TICK_COUNT 100000000

static int __init calibrate_APIC_clock(void)
static void __init calibrate_APIC_clock(void)
{
unsigned apic, apic_start;
unsigned long tsc, tsc_start;
Expand Down Expand Up @@ -855,17 +857,14 @@ static int __init calibrate_APIC_clock(void)
result = (apic_start - apic) * 1000L * tsc_khz /
(tsc - tsc_start);
}
printk("result %d\n", result);

printk(KERN_DEBUG "APIC timer calibration result %d\n", result);

printk(KERN_INFO "Detected %d.%03d MHz APIC timer.\n",
result / 1000 / 1000, result / 1000 % 1000);

return result * APIC_DIVISOR / HZ;
calibration_result = result * APIC_DIVISOR / HZ;
}

static unsigned int calibration_result;

void __init setup_boot_APIC_clock (void)
{
if (disable_apic_timer) {
Expand All @@ -878,7 +877,7 @@ void __init setup_boot_APIC_clock (void)

local_irq_disable();

calibration_result = calibrate_APIC_clock();
calibrate_APIC_clock();
/*
* Now set up the timer for real.
*/
Expand Down Expand Up @@ -985,8 +984,6 @@ void setup_APIC_extended_lvt(unsigned char lvt_off, unsigned char vector,
apic_write(reg, v);
}

#undef APIC_DIVISOR

/*
* Local timer interrupt handler. It does both profiling and
* process statistics/rescheduling.
Expand Down

0 comments on commit d03030e

Please sign in to comment.