Skip to content

Commit

Permalink
[POWERPC] Move phys_addr_t definition into asm/types.h
Browse files Browse the repository at this point in the history
Moved phys_addr_t out of mmu-*.h and into asm/types.h so we can use it in
places that before would have caused recursive includes.

For example to use phys_addr_t in <asm/page.h> we would have included
<asm/mmu.h> which would have possibly included <asm/mmu-hash64.h> which
includes <asm/page.h>.  Wheeee recursive include.

CONFIG_PHYS_64BIT is a bit counterintuitive in light of ppc64 systems
and thus the config option is only used for ppc32 systems with >32-bit
physical addresses (44x, 85xx, 745x, etc.).

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Kumar Gala authored and Paul Mackerras committed Apr 16, 2008
1 parent 4846c5d commit d04ceb3
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 17 deletions.
2 changes: 0 additions & 2 deletions include/asm-powerpc/mmu-40x.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@

#ifndef __ASSEMBLY__

typedef unsigned long phys_addr_t;

typedef struct {
unsigned long id;
unsigned long vdso_base;
Expand Down
2 changes: 0 additions & 2 deletions include/asm-powerpc/mmu-44x.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@

#ifndef __ASSEMBLY__

typedef unsigned long long phys_addr_t;

typedef struct {
unsigned long id;
unsigned long vdso_base;
Expand Down
2 changes: 0 additions & 2 deletions include/asm-powerpc/mmu-8xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@
#define SPRN_M_TW 799

#ifndef __ASSEMBLY__
typedef unsigned long phys_addr_t;

typedef struct {
unsigned long id;
unsigned long vdso_base;
Expand Down
6 changes: 0 additions & 6 deletions include/asm-powerpc/mmu-fsl-booke.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,6 @@

#ifndef __ASSEMBLY__

#ifndef CONFIG_PHYS_64BIT
typedef unsigned long phys_addr_t;
#else
typedef unsigned long long phys_addr_t;
#endif

typedef struct {
unsigned long id;
unsigned long vdso_base;
Expand Down
2 changes: 0 additions & 2 deletions include/asm-powerpc/mmu-hash32.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ typedef struct {
unsigned long vdso_base;
} mm_context_t;

typedef unsigned long phys_addr_t;

#endif /* !__ASSEMBLY__ */

#endif /* _ASM_POWERPC_MMU_HASH32_H_ */
3 changes: 0 additions & 3 deletions include/asm-powerpc/mmu-hash64.h
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,6 @@ static inline unsigned long get_vsid(unsigned long context, unsigned long ea,
VSID_MODULUS_256M)
#define KERNEL_VSID(ea) VSID_SCRAMBLE(GET_ESID(ea))

/* Physical address used by some IO functions */
typedef unsigned long phys_addr_t;

#endif /* __ASSEMBLY__ */

#endif /* _ASM_POWERPC_MMU_HASH64_H_ */
7 changes: 7 additions & 0 deletions include/asm-powerpc/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ typedef unsigned long long u64;

typedef __vector128 vector128;

/* Physical address used by some IO functions */
#if defined(CONFIG_PPC64) || defined(CONFIG_PHYS_64BIT)
typedef u64 phys_addr_t;
#else
typedef u32 phys_addr_t;
#endif

#ifdef __powerpc64__
typedef u64 dma_addr_t;
#else
Expand Down

0 comments on commit d04ceb3

Please sign in to comment.