Skip to content

Commit

Permalink
Char: ds1286, eliminate busy waiting
Browse files Browse the repository at this point in the history
ds1286_get_time(); is not called from atomic context, sleep for 20 ms is
better choice than a (home-made) busy waiting for such a situation.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Slaby authored and Linus Torvalds committed Oct 16, 2008
1 parent 4cea5ce commit d05abab
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/char/ds1286.c
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,6 @@ static void ds1286_get_time(struct rtc_time *rtc_tm)
{
unsigned char save_control;
unsigned long flags;
unsigned long uip_watchdog = jiffies;

/*
* read RTC once any update in progress is done. The update
Expand All @@ -456,8 +455,7 @@ static void ds1286_get_time(struct rtc_time *rtc_tm)
*/

if (ds1286_is_updating() != 0)
while (time_before(jiffies, uip_watchdog + 2*HZ/100))
barrier();
msleep(20);

/*
* Only the values that we read from the RTC are set. We leave
Expand Down

0 comments on commit d05abab

Please sign in to comment.