Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 2883
b: refs/heads/master
c: ca05fea
h: refs/heads/master
i:
  2881: 7d8935b
  2879: 5c17fc2
v: v3
  • Loading branch information
Natalie Protasevich authored and Linus Torvalds committed Jun 23, 2005
1 parent 32c0722 commit d060d9b
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 20 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 7c1def1652c6c1a95eafca2991baace34afaed0f
refs/heads/master: ca05fea6db5259c6d62e517c41d448a4249175f4
10 changes: 6 additions & 4 deletions trunk/arch/i386/kernel/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1658,6 +1658,12 @@ static void __init setup_ioapic_ids_from_mpc(void)
unsigned char old_id;
unsigned long flags;

/*
* Don't check I/O APIC IDs for xAPIC systems. They have
* no meaning without the serial APIC bus.
*/
if (!(boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && boot_cpu_data.x86 < 15))
return;
/*
* This is broken; anything with a real cpu count has to
* circumvent this idiocy regardless.
Expand All @@ -1684,10 +1690,6 @@ static void __init setup_ioapic_ids_from_mpc(void)
mp_ioapics[apic].mpc_apicid = reg_00.bits.ID;
}

/* Don't check I/O APIC IDs for some xAPIC systems. They have
* no meaning without the serial APIC bus. */
if (NO_IOAPIC_CHECK)
continue;
/*
* Sanity check, is the ID really free? Every APIC in a
* system must have a unique ID or we get lots of nice
Expand Down
5 changes: 4 additions & 1 deletion trunk/arch/i386/kernel/mpparse.c
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,10 @@ void __init mp_register_ioapic (
mp_ioapics[idx].mpc_apicaddr = address;

set_fixmap_nocache(FIX_IO_APIC_BASE_0 + idx, address);
mp_ioapics[idx].mpc_apicid = io_apic_get_unique_id(idx, id);
if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) && (boot_cpu_data.x86 < 15))
mp_ioapics[idx].mpc_apicid = io_apic_get_unique_id(idx, id);
else
mp_ioapics[idx].mpc_apicid = id;
mp_ioapics[idx].mpc_apicver = io_apic_get_version(idx);

/*
Expand Down
1 change: 0 additions & 1 deletion trunk/include/asm-i386/genapic.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ struct genapic {
.int_delivery_mode = INT_DELIVERY_MODE, \
.int_dest_mode = INT_DEST_MODE, \
.no_balance_irq = NO_BALANCE_IRQ, \
.no_ioapic_check = NO_IOAPIC_CHECK, \
.ESR_DISABLE = esr_disable, \
.apic_destination_logical = APIC_DEST_LOGICAL, \
APICFUNC(apic_id_registered), \
Expand Down
2 changes: 0 additions & 2 deletions trunk/include/asm-i386/mach-bigsmp/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
#define NO_BALANCE_IRQ (1)
#define esr_disable (1)

#define NO_IOAPIC_CHECK (0)

static inline int apic_id_registered(void)
{
return (1);
Expand Down
2 changes: 0 additions & 2 deletions trunk/include/asm-i386/mach-default/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ static inline cpumask_t target_cpus(void)
#define NO_BALANCE_IRQ (0)
#define esr_disable (0)

#define NO_IOAPIC_CHECK (0)

#define INT_DELIVERY_MODE dest_LowestPrio
#define INT_DEST_MODE 1 /* logical delivery broadcast to all procs */

Expand Down
2 changes: 0 additions & 2 deletions trunk/include/asm-i386/mach-es7000/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ static inline cpumask_t target_cpus(void)
#define WAKE_SECONDARY_VIA_INIT
#endif

#define NO_IOAPIC_CHECK (1)

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
{
return 0;
Expand Down
1 change: 0 additions & 1 deletion trunk/include/asm-i386/mach-generic/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#define esr_disable (genapic->ESR_DISABLE)
#define NO_BALANCE_IRQ (genapic->no_balance_irq)
#define NO_IOAPIC_CHECK (genapic->no_ioapic_check)
#define INT_DELIVERY_MODE (genapic->int_delivery_mode)
#define INT_DEST_MODE (genapic->int_dest_mode)
#undef APIC_DEST_LOGICAL
Expand Down
2 changes: 0 additions & 2 deletions trunk/include/asm-i386/mach-numaq/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ static inline cpumask_t target_cpus(void)
#define NO_BALANCE_IRQ (1)
#define esr_disable (1)

#define NO_IOAPIC_CHECK (0)

#define INT_DELIVERY_MODE dest_LowestPrio
#define INT_DEST_MODE 0 /* physical delivery on LOCAL quad */

Expand Down
2 changes: 0 additions & 2 deletions trunk/include/asm-i386/mach-summit/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#define esr_disable (1)
#define NO_BALANCE_IRQ (0)

#define NO_IOAPIC_CHECK (1) /* Don't check I/O APIC ID for xAPIC */

/* In clustered mode, the high nibble of APIC ID is a cluster number.
* The low nibble is a 4-bit bitmap. */
#define XAPIC_DEST_CPUS_SHIFT 4
Expand Down
2 changes: 0 additions & 2 deletions trunk/include/asm-i386/mach-visws/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
#define no_balance_irq (0)
#define esr_disable (0)

#define NO_IOAPIC_CHECK (0)

#define INT_DELIVERY_MODE dest_LowestPrio
#define INT_DEST_MODE 1 /* logical delivery broadcast to all procs */

Expand Down

0 comments on commit d060d9b

Please sign in to comment.