Skip to content

Commit

Permalink
staging: tidspbridge: remove dmm_init() and dmm_exit()
Browse files Browse the repository at this point in the history
The dmm module has a dmm_init() and a dmm_exit() whose only purpose is
to keep a reference counting which is not used at all.

This patch removes these functions and the reference count variable.

There is no functional changes.

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Víctor Manuel Jáquez Leal authored and Greg Kroah-Hartman committed Mar 9, 2012
1 parent a71aa39 commit d071c0e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 42 deletions.
4 changes: 0 additions & 4 deletions drivers/staging/tidspbridge/include/dspbridge/dmm.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@ extern int dmm_create(struct dmm_object **dmm_manager,
struct dev_object *hdev_obj,
const struct dmm_mgrattrs *mgr_attrts);

extern bool dmm_init(void);

extern void dmm_exit(void);

extern int dmm_create_tables(struct dmm_object *dmm_mgr,
u32 addr, u32 size);

Expand Down
6 changes: 0 additions & 6 deletions drivers/staging/tidspbridge/pmgr/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -657,9 +657,6 @@ int dev_get_bridge_context(struct dev_object *hdev_obj,
void dev_exit(void)
{
refs--;

if (refs == 0)
dmm_exit();
}

/*
Expand All @@ -671,9 +668,6 @@ bool dev_init(void)
{
bool ret = true;

if (refs == 0)
dmm_init();

if (ret)
refs++;

Expand Down
32 changes: 0 additions & 32 deletions drivers/staging/tidspbridge/pmgr/dmm.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ struct dmm_object {
spinlock_t dmm_lock; /* Lock to access dmm mgr */
};

/* ----------------------------------- Globals */
static u32 refs; /* module reference count */
struct map_page {
u32 region_size:15;
u32 mapped_size:15;
Expand Down Expand Up @@ -171,18 +169,6 @@ int dmm_delete_tables(struct dmm_object *dmm_mgr)
return status;
}

/*
* ======== dmm_exit ========
* Purpose:
* Discontinue usage of module; free resources when reference count
* reaches 0.
*/
void dmm_exit(void)
{

refs--;
}

/*
* ======== dmm_get_handle ========
* Purpose:
Expand All @@ -205,24 +191,6 @@ int dmm_get_handle(void *hprocessor, struct dmm_object **dmm_manager)
return status;
}

/*
* ======== dmm_init ========
* Purpose:
* Initializes private state of DMM module.
*/
bool dmm_init(void)
{
bool ret = true;

if (ret)
refs++;

virtual_mapping_table = NULL;
table_size = 0;

return ret;
}

/*
* ======== dmm_map_memory ========
* Purpose:
Expand Down

0 comments on commit d071c0e

Please sign in to comment.