Skip to content

Commit

Permalink
ide: remove ide_hwif_release_regions()
Browse files Browse the repository at this point in the history
All host drivers using ide_unregister()/module_exit() have been fixed
to manage resources themselves so this function can be removed now.

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Apr 26, 2008
1 parent eb716be commit d083c03
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
25 changes: 0 additions & 25 deletions drivers/ide/ide.c
Original file line number Diff line number Diff line change
Expand Up @@ -277,29 +277,6 @@ int ide_hwif_request_regions(ide_hwif_t *hwif)
return -EBUSY;
}

/**
* ide_hwif_release_regions - free IDE resources
*
* Note that we only release the standard ports,
* and do not even try to handle any extra ports
* allocated for weird IDE interface chipsets.
*
* Note also that we don't yet handle mmio resources here. More
* importantly our caller should be doing this so we need to
* restructure this as a helper function for drivers.
*/

void ide_hwif_release_regions(ide_hwif_t *hwif)
{
if (hwif->mmio)
return;

if (hwif->io_ports[IDE_CONTROL_OFFSET])
release_region(hwif->io_ports[IDE_CONTROL_OFFSET], 1);

release_region(hwif->io_ports[IDE_DATA_OFFSET], 8);
}

void ide_remove_port_from_hwgroup(ide_hwif_t *hwif)
{
ide_hwgroup_t *hwgroup = hwif->hwgroup;
Expand Down Expand Up @@ -438,8 +415,6 @@ void ide_unregister(unsigned int index)
if (hwif->dma_base)
(void)ide_release_dma(hwif);

ide_hwif_release_regions(hwif);

/* restore hwif data to pristine status */
ide_init_port_data(hwif, index);

Expand Down
1 change: 0 additions & 1 deletion include/linux/ide.h
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,6 @@ static inline void ide_acpi_set_state(ide_hwif_t *hwif, int on) {}

void ide_remove_port_from_hwgroup(ide_hwif_t *);
extern int ide_hwif_request_regions(ide_hwif_t *hwif);
extern void ide_hwif_release_regions(ide_hwif_t* hwif);
void ide_unregister(unsigned int);

void ide_register_region(struct gendisk *);
Expand Down

0 comments on commit d083c03

Please sign in to comment.