Skip to content

Commit

Permalink
be2net: remove wrong and unnecessary calls to netif_carrier_off()
Browse files Browse the repository at this point in the history
1) In be_probe(), as soon as the MCC Q is created a gratuitous link status
event is received and processed. Accordingly netif_carrier_off/on() is called.
The extra netif_carrier_off() call in probe can race with this and cause wrong
state.

2) be_close() need not call netif_carrier_off(). It is OK to show the actual
link state even when the device is administratively down.

Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sathya Perla authored and David S. Miller committed Aug 3, 2011
1 parent a9b3cd7 commit d09f698
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/benet/be_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2217,7 +2217,6 @@ static int be_close(struct net_device *netdev)

be_async_mcc_disable(adapter);

netif_carrier_off(netdev);
adapter->link_up = false;

if (!lancer_chip(adapter))
Expand Down Expand Up @@ -3345,7 +3344,6 @@ static int __devinit be_probe(struct pci_dev *pdev,
status = register_netdev(netdev);
if (status != 0)
goto unsetup;
netif_carrier_off(netdev);

if (be_physfn(adapter) && adapter->sriov_enabled) {
u8 mac_speed;
Expand Down

0 comments on commit d09f698

Please sign in to comment.