Skip to content

Commit

Permalink
nfs: take i_mutex during direct I/O reads
Browse files Browse the repository at this point in the history
We'll need the i_mutex to prevent i_dio_count from incrementing while
truncate is waiting for it to reach zero, and protects against having
the pagecache repopulated after we flushed it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
  • Loading branch information
Christoph Hellwig authored and Trond Myklebust committed Jan 13, 2014
1 parent 22cd1bf commit d0b9875
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions fs/nfs/direct.c
Original file line number Diff line number Diff line change
Expand Up @@ -500,16 +500,17 @@ ssize_t nfs_file_direct_read(struct kiocb *iocb, const struct iovec *iov,
if (!count)
goto out;

mutex_lock(&inode->i_mutex);
result = nfs_sync_mapping(mapping);
if (result)
goto out;
goto out_unlock;

task_io_account_read(count);

result = -ENOMEM;
dreq = nfs_direct_req_alloc();
if (dreq == NULL)
goto out;
goto out_unlock;

dreq->inode = inode;
dreq->bytes_left = iov_length(iov, nr_segs);
Expand All @@ -525,13 +526,22 @@ ssize_t nfs_file_direct_read(struct kiocb *iocb, const struct iovec *iov,

NFS_I(inode)->read_io += iov_length(iov, nr_segs);
result = nfs_direct_read_schedule_iovec(dreq, iov, nr_segs, pos, uio);

mutex_unlock(&inode->i_mutex);

if (!result) {
result = nfs_direct_wait(dreq);
if (result > 0)
iocb->ki_pos = pos + result;
}

nfs_direct_req_release(dreq);
return result;

out_release:
nfs_direct_req_release(dreq);
out_unlock:
mutex_unlock(&inode->i_mutex);
out:
return result;
}
Expand Down

0 comments on commit d0b9875

Please sign in to comment.