Skip to content

Commit

Permalink
staging: xgifb: clean up register access types
Browse files Browse the repository at this point in the history
Make type usage consistent. Use u8 for HW registers and unsigned for
bitmasks.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Aaro Koskinen authored and Greg Kroah-Hartman committed Mar 14, 2011
1 parent dc50556 commit d0e23bd
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 18 deletions.
23 changes: 10 additions & 13 deletions drivers/staging/xgifb/vb_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,46 +8,43 @@

#include "vb_util.h"

void xgifb_reg_set(unsigned long port, unsigned short index,
unsigned short data)
void xgifb_reg_set(unsigned long port, u8 index, u8 data)
{
outb(index, port);
outb(data, port + 1);
}

unsigned char xgifb_reg_get(unsigned long port, unsigned short index)
u8 xgifb_reg_get(unsigned long port, u8 index)
{
unsigned char data;
u8 data;

outb(index, port);
data = inb(port + 1);
return data;
}

void xgifb_reg_and_or(unsigned long Port, unsigned short Index,
unsigned short DataAND, unsigned short DataOR)
void xgifb_reg_and_or(unsigned long Port, u8 Index,
unsigned DataAND, unsigned DataOR)
{
unsigned short temp;
u8 temp;

temp = xgifb_reg_get(Port, Index); /* XGINew_Part1Port index 02 */
temp = (temp & (DataAND)) | DataOR;
xgifb_reg_set(Port, Index, temp);
}

void xgifb_reg_and(unsigned long Port, unsigned short Index,
unsigned short DataAND)
void xgifb_reg_and(unsigned long Port, u8 Index, unsigned DataAND)
{
unsigned short temp;
u8 temp;

temp = xgifb_reg_get(Port, Index); /* XGINew_Part1Port index 02 */
temp &= DataAND;
xgifb_reg_set(Port, Index, temp);
}

void xgifb_reg_or(unsigned long Port, unsigned short Index,
unsigned short DataOR)
void xgifb_reg_or(unsigned long Port, u8 Index, unsigned DataOR)
{
unsigned short temp;
u8 temp;

temp = xgifb_reg_get(Port, Index); /* XGINew_Part1Port index 02 */
temp |= DataOR;
Expand Down
10 changes: 5 additions & 5 deletions drivers/staging/xgifb/vb_util.h
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#ifndef _VBUTIL_
#define _VBUTIL_
extern void xgifb_reg_set(unsigned long, unsigned short, unsigned short);
extern unsigned char xgifb_reg_get(unsigned long, unsigned short);
extern void xgifb_reg_or(unsigned long, unsigned short, unsigned short);
extern void xgifb_reg_and(unsigned long, unsigned short, unsigned short);
extern void xgifb_reg_and_or(unsigned long, unsigned short, unsigned short, unsigned short);
extern void xgifb_reg_set(unsigned long, u8, u8);
extern u8 xgifb_reg_get(unsigned long, u8);
extern void xgifb_reg_or(unsigned long, u8, unsigned);
extern void xgifb_reg_and(unsigned long, u8, unsigned);
extern void xgifb_reg_and_or(unsigned long, u8, unsigned, unsigned);
#endif

0 comments on commit d0e23bd

Please sign in to comment.