Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 331659
b: refs/heads/master
c: 4e1105a
h: refs/heads/master
i:
  331657: b1fb41d
  331655: b4fa13f
v: v3
  • Loading branch information
Alex Elder committed Oct 1, 2012
1 parent 84b243f commit d115ced
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3feeb8946739d980fb0922bf68363552a493a49c
refs/heads/master: 4e1105a299adf7ac421d42a8be05205f51610f3c
11 changes: 5 additions & 6 deletions trunk/drivers/block/rbd.c
Original file line number Diff line number Diff line change
Expand Up @@ -644,28 +644,28 @@ static int snap_by_name(struct rbd_image_header *header, const char *snap_name,
return -ENOENT;
}

static int rbd_header_set_snap(struct rbd_device *rbd_dev)
static int rbd_header_set_snap(struct rbd_device *rbd_dev, char *snap_name)
{
int ret;

down_write(&rbd_dev->header_rwsem);

if (!memcmp(rbd_dev->mapping.snap_name, RBD_SNAP_HEAD_NAME,
if (!memcmp(snap_name, RBD_SNAP_HEAD_NAME,
sizeof (RBD_SNAP_HEAD_NAME))) {
rbd_dev->mapping.snap_id = CEPH_NOSNAP;
rbd_dev->mapping.size = rbd_dev->header.image_size;
rbd_dev->mapping.snap_exists = false;
rbd_dev->mapping.read_only = rbd_dev->rbd_opts.read_only;
} else {
ret = snap_by_name(&rbd_dev->header,
rbd_dev->mapping.snap_name,
ret = snap_by_name(&rbd_dev->header, snap_name,
&rbd_dev->mapping.snap_id,
&rbd_dev->mapping.size);
if (ret < 0)
goto done;
rbd_dev->mapping.snap_exists = true;
rbd_dev->mapping.read_only = true;
}
rbd_dev->mapping.snap_name = snap_name;

ret = 0;
done:
Expand Down Expand Up @@ -1888,7 +1888,7 @@ static int rbd_init_disk(struct rbd_device *rbd_dev)
if (rc)
return rc;

rc = rbd_header_set_snap(rbd_dev);
rc = rbd_header_set_snap(rbd_dev, snap_name);
if (rc)
return rc;

Expand Down Expand Up @@ -2600,7 +2600,6 @@ static ssize_t rbd_add(struct bus_type *bus,
rc = PTR_ERR(snap_name);
goto err_put_id;
}
rbd_dev->mapping.snap_name = snap_name;

rc = rbd_get_client(rbd_dev, mon_addrs, mon_addrs_size - 1, options);
if (rc < 0)
Expand Down

0 comments on commit d115ced

Please sign in to comment.