Skip to content

Commit

Permalink
hci_usb: remove code obfuscation
Browse files Browse the repository at this point in the history
_urb_free is an alias for kfree... making code longer & harder to
read. Remove it.

Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pavel Machek authored and David S. Miller committed Apr 20, 2008
1 parent b132fba commit d129f18
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
10 changes: 5 additions & 5 deletions drivers/bluetooth/hci_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ static int hci_usb_intr_rx_submit(struct hci_usb *husb)
BT_ERR("%s intr rx submit failed urb %p err %d",
husb->hdev->name, urb, err);
_urb_unlink(_urb);
_urb_free(_urb);
kfree(_urb);
kfree(buf);
}
return err;
Expand Down Expand Up @@ -302,7 +302,7 @@ static int hci_usb_bulk_rx_submit(struct hci_usb *husb)
BT_ERR("%s bulk rx submit failed urb %p err %d",
husb->hdev->name, urb, err);
_urb_unlink(_urb);
_urb_free(_urb);
kfree(_urb);
kfree(buf);
}
return err;
Expand Down Expand Up @@ -353,7 +353,7 @@ static int hci_usb_isoc_rx_submit(struct hci_usb *husb)
BT_ERR("%s isoc rx submit failed urb %p err %d",
husb->hdev->name, urb, err);
_urb_unlink(_urb);
_urb_free(_urb);
kfree(_urb);
kfree(buf);
}
return err;
Expand Down Expand Up @@ -431,7 +431,7 @@ static void hci_usb_unlink_urbs(struct hci_usb *husb)
husb->hdev->name, _urb, _urb->type, urb);
kfree(urb->setup_packet);
kfree(urb->transfer_buffer);
_urb_free(_urb);
kfree(_urb);
}
}
}
Expand Down Expand Up @@ -490,7 +490,7 @@ static inline int hci_usb_send_ctrl(struct hci_usb *husb, struct sk_buff *skb)

dr = kmalloc(sizeof(*dr), GFP_ATOMIC);
if (!dr) {
_urb_free(_urb);
kfree(_urb);
return -ENOMEM;
}
} else
Expand Down
5 changes: 0 additions & 5 deletions drivers/bluetooth/hci_usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@ struct _urb {
struct urb urb;
};

static inline void _urb_free(struct _urb *_urb)
{
kfree(_urb);
}

static inline void _urb_queue_init(struct _urb_queue *q)
{
INIT_LIST_HEAD(&q->head);
Expand Down

0 comments on commit d129f18

Please sign in to comment.