Skip to content

Commit

Permalink
spi: omap-100k: Fix memory leak
Browse files Browse the repository at this point in the history
The memory allocated for cs is not freed anywhere.
Convert to use devm_kzalloc to fix the memory leak.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Axel Lin authored and Mark Brown committed Mar 29, 2014
1 parent 31804f6 commit d1c18ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-omap-100k.c
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ static int omap1_spi100k_setup(struct spi_device *spi)
spi100k = spi_master_get_devdata(spi->master);

if (!cs) {
cs = kzalloc(sizeof(*cs), GFP_KERNEL);
cs = devm_kzalloc(&spi->dev, sizeof(*cs), GFP_KERNEL);
if (!cs)
return -ENOMEM;
cs->base = spi100k->base + spi->chip_select * 0x14;
Expand Down

0 comments on commit d1c18ca

Please sign in to comment.