---

yaml --- r: 19483 b: refs/heads/master c: eb9bdaa h: refs/heads/master i: 19481: 4ecde32 19479: 16266d6 v: v3
git-mirror · Jan 27, 2006 · d1c4504 · d1c4504
1 parent f67eb43
commit d1c4504
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 17cbbafe8e82bde4258e407ce043b61f4f9a350f
+refs/heads/master: eb9bdaa3f3b9d30d09bcad47037216aa39639b8e
diff --git a/trunk/fs/cifs/file.c b/trunk/fs/cifs/file.c
@@ -1190,14 +1190,20 @@ static int cifs_writepages(struct address_space *mapping,
 					/* BB what if continued retry is
 					   requested via mount flags? */
 					set_bit(AS_EIO, &mapping->flags);
-					SetPageError(page);
 				} else {
 					cifs_stats_bytes_written(cifs_sb->tcon,
 								 bytes_written);
 				}
 			}
 			for (i = 0; i < n_iov; i++) {
 				page = pvec.pages[first + i];
+				/* Should we also set page error on
+				success rc but too little data written? */
+				/* BB investigate retry logic on temporary
+				server crash cases and how recovery works
+				when page marked as error */ 
+				if(rc)
+					SetPageError(page);
 				kunmap(page);
 				unlock_page(page);
 				page_cache_release(page);