Skip to content

Commit

Permalink
panic, smp: provide smp_send_stop() wrapper on UP too
Browse files Browse the repository at this point in the history
Impact: cleanup, no code changed

Remove an ugly #ifdef CONFIG_SMP from panic(), by providing
an smp_send_stop() wrapper on UP too.

LKML-Reference: <49B91A7E.76E4.0078.0@novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Mar 13, 2009
1 parent ffd71da commit d1dedb5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 3 additions & 1 deletion include/linux/smp.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ int smp_call_function_single(int cpuid, void (*func) (void *info), void *info,
/*
* main cross-CPU interfaces, handles INIT, TLB flush, STOP, etc.
* (defined in asm header):
*/
*/

/*
* stops all CPUs but the current one:
Expand Down Expand Up @@ -122,6 +122,8 @@ extern unsigned int setup_max_cpus;

#else /* !SMP */

static inline void smp_send_stop(void) { }

/*
* These macros fold the SMP functionality into a single CPU system
*/
Expand Down
2 changes: 0 additions & 2 deletions kernel/panic.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,12 @@ NORET_TYPE void panic(const char * fmt, ...)
*/
crash_kexec(NULL);

#ifdef CONFIG_SMP
/*
* Note smp_send_stop is the usual smp shutdown function, which
* unfortunately means it may not be hardened to work in a panic
* situation.
*/
smp_send_stop();
#endif

atomic_notifier_call_chain(&panic_notifier_list, 0, buf);

Expand Down

0 comments on commit d1dedb5

Please sign in to comment.